From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] cvsexportcommit: be graceful when "cvs status" reorders
 the arguments
Date: Mon, 18 Feb 2008 10:36:59 -0800
Message-ID: <7v1w7ap0vo.fsf@gitster.siamese.dyndns.org>
References: <alpine.LSU.1.00.0802180127100.30505@racer.site>
 <7vbq6fvudp.fsf@gitster.siamese.dyndns.org>
 <alpine.LSU.1.00.0802181627340.30505@racer.site>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: git@vger.kernel.org, Martin Langhoff <martin@catalyst.net.nz>,
	Robin Rosenberg <robin.rosenberg@dewire.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
X-From: git-owner@vger.kernel.org Mon Feb 18 19:38:08 2008
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1JRAsP-0004FA-VH
	for gcvg-git-2@gmane.org; Mon, 18 Feb 2008 19:38:06 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753026AbYBRSha (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Mon, 18 Feb 2008 13:37:30 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752826AbYBRSha
	(ORCPT <rfc822;git-outgoing>); Mon, 18 Feb 2008 13:37:30 -0500
Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:36420 "EHLO
	sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751452AbYBRSh3 (ORCPT <rfc822;git@vger.kernel.org>);
	Mon, 18 Feb 2008 13:37:29 -0500
Received: from a-sasl-quonix.pobox.com (localhost [127.0.0.1])
	by a-sasl-quonix.pobox.com (Postfix) with ESMTP id D618E48C4;
	Mon, 18 Feb 2008 13:37:23 -0500 (EST)
Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client
 certificate requested) by a-sasl-quonix.pobox.com (Postfix) with ESMTP id
 D2F2148C2; Mon, 18 Feb 2008 13:37:16 -0500 (EST)
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/74327>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> The script uses File::Basename upfront so perhaps just simply...
>
> I tried that.  But as the file need not exist, "basename" went on strike.
>
> So I'll keep the (ugly) version.

The reason why "basename" is not being used needs documented in
the code then.  The next person will likely to make the same
mistake as I did.