From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Brian Downing <bdowning@lavos.net>,
Steffen Prohaska <prohaska@zib.de>,
git@vger.kernel.org, msysgit@googlegroups.com
Subject: Re: [PATCH] compat: Add simplified merge sort implementation from glibc
Date: Sat, 02 Feb 2008 22:22:44 -0800 [thread overview]
Message-ID: <7v1w7u1ruz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LSU.1.00.0802030231080.7372@racer.site> (Johannes Schindelin's message of "Sun, 3 Feb 2008 02:37:27 +0000 (GMT)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> So I would like this to go in, evidently, if only as a starting point for
> people to play with sorting algorithms, to find the one which is optimal
> for our general use (we have quite some uses where we put in _almost_
> sorted data, which seems to be the worst-case for many sorting
> algorithms).
I do not think we want to spend arguing over the last few
percent to get anything ultra-fast. The aim for compat/ is to
have a replacement for unusable platform-supplied stuff.
The patch looked fine, thanks.
If I may add a bikeshed comment, I probably would have modelled
the make variable, not after ssl-with-crypto and libiconv, but
after {arm,mozilla,ppc}-sha1, if I were naming it. This is not
like an absolute must-to-have: "on this platform, libc is not
enough and we NEED to explicitly ask for -liconv". It is more
like a choose-to-use: "we could use openssl sha1 implementation,
but I choose to use Mozilla one".
next prev parent reply other threads:[~2008-02-03 6:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 1:11 [PATCH] compat: Add simplified merge sort implementation from glibc Brian Downing
[not found] ` <20080203011130.GK26392-oU/tDdhfGLReoWH0uzbU5w@public.gmane.org>
2008-02-03 2:37 ` Johannes Schindelin
2008-02-03 4:50 ` Brian Downing
[not found] ` <20080203045033.GL26392-oU/tDdhfGLReoWH0uzbU5w@public.gmane.org>
2008-02-03 21:09 ` Johannes Schindelin
2008-02-05 10:19 ` Mike Ralphson
2008-02-03 6:22 ` Junio C Hamano [this message]
2008-02-04 0:05 ` Edgar Toernig
[not found] ` <20080204010552.03541642.froese-Mmb7MZpHnFY@public.gmane.org>
2008-02-04 2:46 ` Brian Downing
[not found] ` <1202209509-13760-1-git-send-email-bdowning@lavos.net>
2008-02-05 14:11 ` Brian Downing
2008-02-05 20:02 ` Junio C Hamano
2008-02-05 21:07 ` Brian Downing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1w7u1ruz.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=bdowning@lavos.net \
--cc=git@vger.kernel.org \
--cc=msysgit@googlegroups.com \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).