Re: [PATCH] More test cases for sanitized path names

[Junio C Hamano <gitster@pobox.com>]

Junio C Hamano <gitster@pobox.com> writes:

> Robin Rosenberg <robin.rosenberg.lists@dewire.com> writes:
>
>>> > +test_expect_failure 'add a directory outside the work tree' '
>>> > +	d1="$(cd .. ; pwd)" &&
>>> > +	git add "$d1"
>>> > +	echo $?
>>> > +'
>>
>> Oops. Remove the echo $?. It still fails, i.e. git add succeeds when
>> it shouldn't. I was double checking it just before sending the patch.
>
> Ah, you found breakages.

I haven't looked at the code, but I suspect that "git add" and
anything that uses the same logic as "ls-files --error-unmatch"
would still not work with the setup patch.

The updated get_pathspec() issues a warning message and returns
the result that omits paths outside of the work tree.  It does
not die (and it is intentional, by the way).  The callers that
expect to always receive the same number of paths in the return
value as argv+i they pass to get_pathspec() should be updated to
notice that they got less than they passed in, if they care
about this error condition, and --error-unmatch codepath is one
of them.  I did not touch that in the weatherbaloon patch.