From: Junio C Hamano <gitster@pobox.com>
To: "Grégoire Barbier" <gb@gbarbier.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] added #define DEFAULT_MAX_REQUESTS for USE_CURL_MULTI mode
Date: Sun, 20 Jan 2008 16:13:49 -0800 [thread overview]
Message-ID: <7v1w8c6nnm.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1200756171-11696-5-git-send-email-gb@gbarbier.org> (Grégoire Barbier's message of "Sat, 19 Jan 2008 16:22:51 +0100")
Grégoire Barbier <gb@gbarbier.org> writes:
> From: Gregoire Barbier <gb@gbarbier.org>
>
> I'm not sure of which value is the good one, but 4 seems good since it's
> not very high which would lead to resouce consumption problems.
> ---
> http.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/http.c b/http.c
> index 8b04ae9..7b1bcb8 100644
> --- a/http.c
> +++ b/http.c
> @@ -4,6 +4,7 @@ int data_received;
> int active_requests = 0;
>
> #ifdef USE_CURL_MULTI
> +#define DEFAULT_MAX_REQUESTS 4
> static int max_requests = -1;
> static CURLM *curlm;
> #endif
Why is this needed?
How does this interact with an existing #define in http.h that
defines it to 5?
next prev parent reply other threads:[~2008-01-21 0:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-19 15:22 [PATCH] http-push: fix webdav lock leak Grégoire Barbier
2008-01-19 15:22 ` [PATCH] http-push: fail when info/refs exists and is already locked Grégoire Barbier
2008-01-19 15:22 ` [PATCH] http-push: more explicit error message with bad URL or password Grégoire Barbier
2008-01-19 15:22 ` [PATCH] http-push and http-fetch: handle URLs without leading / Grégoire Barbier
2008-01-19 15:22 ` [PATCH] added #define DEFAULT_MAX_REQUESTS for USE_CURL_MULTI mode Grégoire Barbier
2008-01-21 0:13 ` Junio C Hamano [this message]
2008-01-21 9:57 ` Grégoire Barbier
2008-01-21 10:19 ` Junio C Hamano
2008-01-19 15:29 ` [PATCH] http-push and http-fetch: handle URLs without leading / Mike Hommey
2008-01-19 23:16 ` Johannes Schindelin
2008-01-19 23:14 ` Johannes Schindelin
2008-01-20 23:00 ` [PATCH] http-push: more explicit error message with bad URL or password Junio C Hamano
2008-01-19 23:08 ` [PATCH] http-push: fix webdav lock leak Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1w8c6nnm.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=gb@gbarbier.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).