From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Marco Costalba <mcostalba@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Optimize prefixcmp()
Date: Wed, 02 Jan 2008 10:52:13 -0800 [thread overview]
Message-ID: <7v1w90xdpe.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <477BC2DA.6000105@lsrfire.ath.cx> (René Scharfe's message of "Wed, 02 Jan 2008 17:59:06 +0100")
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> prefixcmp() was already optimized before -- only for a different use
> case. At a number of callsites the prefix is a string literal, which
> allowed the compiler to perform the strlen() call at compile time.
>
> The patch increases the text size considerably: the file "git" is
> 2,620,938 without and 2,640,450 with the patch in my build (there are
> 136 callsites in builtin*.c). The new version of prefixcmp() shouldn't
> be inlined any more, as the benefit of doing so is gone.
Yuck, you are absolutely right. The late thread may have been
well intentioned but resulted in this regression. Sorry about
that.
I presume that all callers with constant prefix are outside
performance critical parts? Can we simply uninline the function
in that case?
next prev parent reply other threads:[~2008-01-02 18:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-29 18:01 [PATCH] Speedup prefixcmp() common case Marco Costalba
2007-12-29 19:22 ` [PATCH] Optimize prefixcmp() Johannes Schindelin
2007-12-29 20:39 ` Marco Costalba
2007-12-29 22:15 ` Johannes Schindelin
2007-12-29 22:44 ` Marco Costalba
2007-12-30 13:02 ` Marco Costalba
2007-12-30 13:55 ` Pierre Habouzit
2007-12-30 13:58 ` Pierre Habouzit
2007-12-30 14:50 ` Marco Costalba
2007-12-30 15:17 ` Marco Costalba
2007-12-30 15:54 ` Johannes Schindelin
2007-12-29 21:54 ` Andy Parkins
2007-12-30 0:44 ` Junio C Hamano
2008-01-02 16:59 ` René Scharfe
2008-01-02 18:52 ` Junio C Hamano [this message]
2008-01-03 0:45 ` René Scharfe
2007-12-29 19:32 ` [PATCH] Speedup prefixcmp() common case Junio C Hamano
2007-12-29 20:14 ` Marco Costalba
2007-12-30 0:05 ` Junio C Hamano
2007-12-29 20:43 ` Marco Costalba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1w90xdpe.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=mcostalba@gmail.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).