From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: gitzilla@gmail.com,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH] t9600: require cvsps 2.1 to perform tests
Date: Mon, 03 Dec 2007 21:37:54 -0800 [thread overview]
Message-ID: <7v1wa3aukt.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071204014145.GA20145@coredump.intra.peff.net> (Jeff King's message of "Mon, 3 Dec 2007 20:41:45 -0500")
Jeff King <peff@peff.net> writes:
> +cvsps_version=`cvsps -h 2>&1 | sed -ne 's/cvsps version //p'`
> +case "$cvsps_version" in
> +2.1)
> + ;;
> +'')
> + say 'skipping cvsimport tests, cvsps not found'
> + test_done
> + exit
> + ;;
> +*)
> + say 'skipping cvsimport tests, cvsps too old'
> + test_done
> + exit
> + ;;
> +esac
> +
I wonder if it is better to grep for ' [-A] ' instead, like:
cvsps_supports_A=$(cvsps -h 2>&1 | sed -ne '/\[-A\]/p')
case "$cvsps_supports_A" in
'')
say 'skipping cvsimport tests, lacking cvsps that supports -A option'
test_done
exit
esac
next prev parent reply other threads:[~2007-12-04 5:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 12:29 make test failure with latest master A Large Angry SCM
2007-12-02 12:52 ` Jakub Narebski
2007-12-02 14:01 ` A Large Angry SCM
2007-12-02 16:34 ` Jeff King
2007-12-02 23:19 ` A Large Angry SCM
2007-12-02 23:41 ` Johannes Schindelin
2007-12-03 1:59 ` Jeff King
2007-12-03 7:33 ` Johannes Sixt
2007-12-03 7:35 ` Jeff King
2007-12-03 23:10 ` A Large Angry SCM
2007-12-03 23:21 ` Junio C Hamano
2007-12-03 23:25 ` A Large Angry SCM
2007-12-04 1:41 ` [PATCH] t9600: require cvsps 2.1 to perform tests Jeff King
2007-12-04 5:37 ` Junio C Hamano [this message]
2007-12-04 15:44 ` Jeff King
2007-12-04 17:39 ` Junio C Hamano
2007-12-05 1:02 ` Jeff King
2007-12-05 5:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1wa3aukt.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitzilla@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).