From: Junio C Hamano <gitster@pobox.com>
To: Steffen Prohaska <prohaska@zib.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 5/6] push: use same rules as git-rev-parse to resolve refspecs
Date: Mon, 12 Nov 2007 11:51:39 -0800 [thread overview]
Message-ID: <7v1wav44z8.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1194789709671-git-send-email-prohaska@zib.de
Steffen Prohaska <prohaska@zib.de> writes:
> diff --git a/remote.c b/remote.c
> index bec2ba1..28d8eb7 100644
> --- a/remote.c
> +++ b/remote.c
> @@ -519,10 +519,7 @@ static int count_refspec_match(const char *pattern,
> char *name = refs->name;
> int namelen = strlen(name);
>
> - if (namelen < patlen ||
> - memcmp(name + namelen - patlen, pattern, patlen))
> - continue;
> - if (namelen != patlen && name[namelen - patlen - 1] != '/')
> + if (!ref_abbrev_matches_full_with_rules(pattern, name, ref_rev_parse_rules))
> continue;
I vaguely recall that in the old round this check used to be
without negation '!' in the front. I think this version is
correct.
next prev parent reply other threads:[~2007-11-12 19:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 14:01 [REPLACEMENT PATCH 0/6] improve refspec handling in push, refactor matching in fetch Steffen Prohaska
2007-11-11 14:01 ` [PATCH 1/6] push: mention --verbose option in documentation Steffen Prohaska
2007-11-11 14:01 ` [PATCH 2/6] push: teach push to pass --verbose option to transport layer Steffen Prohaska
2007-11-11 14:01 ` [PATCH 3/6] push: support pushing HEAD to real branch name Steffen Prohaska
2007-11-11 14:01 ` [PATCH 4/6] add ref_abbrev_matches_full_with_rules() Steffen Prohaska
2007-11-11 14:01 ` [PATCH 5/6] push: use same rules as git-rev-parse to resolve refspecs Steffen Prohaska
2007-11-11 14:01 ` [PATCH 6/6] refactor fetch's ref matching to use ref_abbrev_matches_full_with_rules() Steffen Prohaska
2007-11-11 14:55 ` Jakub Narebski
2007-11-11 17:31 ` Steffen Prohaska
2007-11-12 19:51 ` Junio C Hamano [this message]
2007-11-12 20:48 ` [PATCH 5/6] push: use same rules as git-rev-parse to resolve refspecs Steffen Prohaska
2007-11-12 19:51 ` [PATCH 4/6] add ref_abbrev_matches_full_with_rules() Junio C Hamano
2007-11-12 20:51 ` Steffen Prohaska
2007-11-11 14:17 ` [PATCH 3/6] push: support pushing HEAD to real branch name Andreas Ericsson
2007-11-11 14:35 ` [REPLACEMENT PATCH " Steffen Prohaska
2007-11-11 14:10 ` [PATCH 1/6] push: mention --verbose option in documentation Steffen Prohaska
2007-11-11 14:14 ` Steffen Prohaska
2007-11-11 19:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1wav44z8.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).