git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH MISC 1/1] Make gcc warning about empty if body go away.
Date: Wed, 07 Nov 2007 17:52:27 -0800	[thread overview]
Message-ID: <7v1wb18pwk.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1194430832-6224-2-git-send-email-madcoder@debian.org> (Pierre Habouzit's message of "Wed, 7 Nov 2007 11:20:26 +0100")

Pierre Habouzit <madcoder@debian.org> writes:

> Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> @@ -204,7 +204,7 @@ static void refresh_index_quietly(void)
>  		if (write_cache(fd, active_cache, active_nr) ||
>  		    close(fd) ||
>  		    commit_locked_index(lock_file))
> -			; /*
> +			(void)0; /*
>  			   * silently ignore it -- we haven't mucked
>  			   * with the real index.
>  			   */

Ok, will apply after reindenting a bit, and adding a quote to
the description that I could not parse on the first reading:

	Make gcc warning about "empty if body" go away.

Thanks.

  parent reply	other threads:[~2007-11-08  1:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 10:20 Preliminary patches to the diff.[hc] parseoptification Pierre Habouzit
2007-11-07 10:20 ` [PATCH MISC 1/1] Make gcc warning about empty if body go away Pierre Habouzit
2007-11-07 10:20   ` [PATCH PARSEOPT 1/4] parse-options new features Pierre Habouzit
2007-11-07 10:20     ` [PATCH PARSEOPT 2/4] Use OPT_SET_INT and OPT_BIT in builtin-branch Pierre Habouzit
2007-11-07 10:20       ` [PATCH PARSEOPT 3/4] Use OPT_BIT in builtin-for-each-ref Pierre Habouzit
2007-11-07 10:20         ` [PATCH PARSEOPT 4/4] Use OPT_BIT in builtin-pack-refs Pierre Habouzit
2007-11-07 10:20           ` [PATCH DIFF-CLEANUP 1/2] Make the diff_options bitfields be an unsigned with explicit masks Pierre Habouzit
2007-11-07 10:20             ` [PATCH DIFF-CLEANUP 2/2] Reorder diff_opt_parse options more logically per topics Pierre Habouzit
2007-11-08  6:39             ` [PATCH DIFF-CLEANUP 1/2] Make the diff_options bitfields be an unsigned with explicit masks Junio C Hamano
2007-11-08  8:17               ` Pierre Habouzit
2007-11-10 19:05               ` [UPDATE " Pierre Habouzit
2007-11-08 23:59     ` [PATCH PARSEOPT 1/4] parse-options new features Junio C Hamano
2007-11-09  0:17       ` Pierre Habouzit
2007-11-08  1:52   ` Junio C Hamano [this message]
2007-11-08  2:01   ` [PATCH MISC 1/1] Make gcc warning about empty if body go away Junio C Hamano
2007-11-08  8:12     ` Pierre Habouzit
2007-11-08  8:41     ` Andreas Ericsson
2007-11-08 15:20       ` Jon Loeliger
2007-11-08 15:47         ` Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1wb18pwk.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=madcoder@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).