From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/3] gitweb: Simplify some gitweb URLs generation
Date: Thu, 01 Nov 2007 15:47:57 -0700 [thread overview]
Message-ID: <7v1wb98twi.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1193918789-16421-1-git-send-email-jnareb@gmail.com
Jakub Narebski <jnareb@gmail.com> writes:
> This series of patches simplifies some gitweb URLs generation by
> providing -replay option to href() subroutine, and then using this
> feature in gitweb code.
>
> Shortlog:
> gitweb: Easier adding/changing parameters to current URL
> gitweb: Use href(-replay=>1, page=>...) to generate pagination links
> gitweb: Use href(-replay=>1, action=>...) to generate alternate views
>
> Diffstat:
> gitweb/gitweb.perl | 82 ++++++++++++++++++++++-----------------------------
> 1 files changed, 35 insertions(+), 47 deletions(-)
If this "-replay" is used carelessly, it could add parameters
that were passed to the page that the original code stripped
away from passing on purpose. Have you checked if the
conversion done with 2/3 and 3/3 are correct (I haven't)?
next prev parent reply other threads:[~2007-11-01 22:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 12:06 [PATCH 0/3] gitweb: Simplify some gitweb URLs generation Jakub Narebski
2007-11-01 12:06 ` Jakub Narebski
2007-11-01 12:06 ` [PATCH 1/3] gitweb: Easier adding/changing parameters to current URL Jakub Narebski
2007-11-01 12:06 ` [PATCH 2/3] gitweb: Use href(-replay=>1, page=>...) to generate pagination links Jakub Narebski
2007-11-01 12:06 ` [PATCH 3/3] gitweb: Use href(-replay=>1, action=>...) to generate alternate views Jakub Narebski
2007-11-01 22:47 ` Junio C Hamano [this message]
2007-11-02 0:18 ` [PATCH 0/3] gitweb: Simplify some gitweb URLs generation Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1wb98twi.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).