git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org, Simon Josefsson <simon@josefsson.org>,
	junkio@cox.net
Subject: Re: [PATCH] show_date(): rename the "relative" parameter to "mode"
Date: Tue, 27 Feb 2007 13:51:43 -0800	[thread overview]
Message-ID: <7v1wkbclqo.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0702271339550.12485@woody.linux-foundation.org> (Linus Torvalds's message of "Tue, 27 Feb 2007 13:41:35 -0800 (PST)")

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Tue, 27 Feb 2007, Johannes Schindelin wrote:
>> 
>> Now, show_date() can print three different kinds of dates: normal,
>> relative and short (%Y-%m-%s) dates.
>> 
>> To achieve this, the "int relative" was changed to "enum date_mode
>> mode", which has three states: DATE_NORMAL, DATE_RELATIVE and
>> DATE_SHORT.
>
> Ack. I think this kind of thing is worth it regardless of any of the other 
> issues (ie the whole "changelog" thing). 

Ack-on-Ack.

  reply	other threads:[~2007-02-27 21:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-27 15:21 [PATCH] show_date(): rename the "relative" parameter to "mode" Johannes Schindelin
2007-02-27 21:41 ` Linus Torvalds
2007-02-27 21:51   ` Junio C Hamano [this message]
2007-02-27 21:59   ` Linus Torvalds
2007-02-27 22:24     ` Johannes Schindelin
2007-02-27 23:04       ` Linus Torvalds
2007-02-27 23:13         ` Johannes Schindelin
2007-02-27 23:09       ` Junio C Hamano
2007-02-27 23:20         ` Johannes Schindelin
2007-02-27 23:34           ` Junio C Hamano
2007-02-27 23:52             ` Johannes Schindelin
2007-02-27 23:59         ` Linus Torvalds
2007-02-27 22:13   ` Johannes Schindelin
2007-02-27 23:02     ` Linus Torvalds
2007-02-27 23:10       ` Johannes Schindelin
2007-02-27 23:53         ` Linus Torvalds
2007-02-27 23:18       ` GNU ChangeLogs, was " Johannes Schindelin
2007-02-28  9:48       ` OT: Favourite log message layout Andy Parkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1wkbclqo.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=simon@josefsson.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).