git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Carl Worth <cworth@cworth.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-status: wording update to deal with deleted files.
Date: Thu, 11 Jan 2007 16:13:06 -0800	[thread overview]
Message-ID: <7v1wm114rx.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <87ac0pxgl2.wl%cworth@cworth.org> (Carl Worth's message of "Thu, 11 Jan 2007 15:56:57 -0800")

Carl Worth <cworth@cworth.org> writes:

> ... So conceptually, the user can be left
> with, "hmm... it's not updated, but how the heck do I update it?".
>
>>  - Suggestion is "git add ... to update what will be committed",
>>    instead of "... to add content to commit";
>>
>>  - If there are removed paths, the above suggestion becomes "git
>>    add/rm ... to update what will be committed";
>
> Here now we do start providing the user with some mechanisms for
> "update". Sometimes we suggest using "add" to update, and sometimes we
> suggest using "add" or "rm" to update. But as you yourself have
> pointed out, you consider "rm" a totally pointless command.

You are twisting my words ;-).

"rm" is pointless for a workflow that always uses "commit -a".
In the same sense, the three categorization "git-status" gives
is pointless -- "changed but not updated" class does not have
any significance if you always do "commit -a".

But that is not the only workflow we encourage.

I do encourage "commit -a" or "commit after update-index" and
frown upon but tolerate "commit <paths>..." --- all of the above
is in line with this world view.   And the categorization and
suggestions are about the latter: "commit after update-index".

Then the issue is how to expose update-index to the end users.
"add" is about adding the content.  What's unfortunate is that
adding a file as zero-length content is still different from
removing it.

Honestly, removing is so different from the norm that I do not
see major inconsistency nor inconvenience, practically nor in
philosophy, to have two separate Porcelain-ish commands, add and
rm, to perform content additions and removal.

  reply	other threads:[~2007-01-12  0:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-11 20:10 Removing files David Kågedal
2007-01-11 21:36 ` Alex Riesen
2007-01-11 22:25   ` Seth Falcon
2007-01-11 22:41 ` Junio C Hamano
2007-01-11 23:19   ` Eric Wong
2007-01-11 23:36   ` Junio C Hamano
2007-01-11 23:37   ` [PATCH] git-status: wording update to deal with deleted files Junio C Hamano
2007-01-11 23:56     ` Carl Worth
2007-01-12  0:13       ` Junio C Hamano [this message]
2007-01-12  1:28         ` Carl Worth
2007-01-12 19:48           ` Jakub Narebski
2007-01-12  0:07     ` Jeff King
2007-01-12 22:13     ` Juergen Ruehle
2007-01-11 23:41 ` Removing files Carl Worth
2007-01-12  0:17   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1wm114rx.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=cworth@cworth.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).