From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: Re: Could we please make "cherry-pick" not add the message by default?
Date: Thu, 05 Oct 2006 17:35:34 -0700 [thread overview]
Message-ID: <7v1wpm5lih.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0610051711310.3952@g5.osdl.org> (Linus Torvalds's message of "Thu, 5 Oct 2006 17:14:29 -0700 (PDT)")
Linus Torvalds <torvalds@osdl.org> writes:
> It appears that more and more people are finding "git cherry-pick", and we
> now have a number of totally inane
>
> cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit
>
> messages in the kernel logs, because I don't want to just re-cherry-pick
> them and edit peoples logs.
>
> Those messages not only make no grammatical sense (you'd say "commit X"
> rather than "X commit"), but they have no point. The original commit is
> not reachable and makes no sense any more, and that's actually likely to
> always be the common case.
>
> So could we just (a) fix the message word order to make sense and (b) make
> it only happen if people explicitly ask for it, rather than by default?
Let's do (c) never show it and make -r a no-op.
next prev parent reply other threads:[~2006-10-06 0:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 0:14 Could we please make "cherry-pick" not add the message by default? Linus Torvalds
2006-10-06 0:35 ` Junio C Hamano [this message]
2006-10-06 0:56 ` [PATCH] cherry-pick: make -r the default Junio C Hamano
2006-10-06 1:20 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1wpm5lih.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).