From: Junio C Hamano <junkio@cox.net>
To: "Santi Béjar" <sbejar@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fetch: Add output for the not fast forward case
Date: Thu, 28 Sep 2006 19:29:00 -0700 [thread overview]
Message-ID: <7v1wpvquc3.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 873babbptl.fsf@gmail.com
Santi Béjar <sbejar@gmail.com> writes:
> This patch follows the notation of the other mail, but for the
> not-fast-forward case I think it makes more sense to use the '...'
> notation.
Again, justification for three-dots not two as others is needed
in the commit log part, not the commentary part.
I tend to agree with you that A...B is nice in this case, _if_
we use A..B for others. Using A..B for others (I am guessing
that you are doing this for Cut & Paste reasons to grab the
whole range as one word) means that we assume users are a lot
more likely to be interested in grabbing A..B as a range than
grabbing only A or B as a point.
I will not discuss if that assumption is correct here, but if we
assume it is, using A...B makes a lot of sense for this case.
After grabbing A..B in other cases, the user can give that to
"git log" to see what the changes between old and new are. In
this non-fast-forward case, if we used three-dots A...B to talk
about the two heads, the user can give it to "git log" to see
how the two non-fast-forward heads have diverged.
So the choice of .. and ... are internally consistent and very
sensible.
The question is if people more often want to grab both as a
range than they want to grab either end point alone. I am
inclined to think your assumption is correct, but am not
absolutely sure.
prev parent reply other threads:[~2006-09-29 2:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 22:15 [PATCH] fetch: Add output for the not fast forward case Santi Béjar
2006-09-29 2:29 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1wpvquc3.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=sbejar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).