From: Junio C Hamano <junkio@cox.net>
To: Martin Waitz <tali@admingilde.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] support cover letter before commit log, using "+++"
Date: Sun, 23 Jul 2006 23:54:22 -0700 [thread overview]
Message-ID: <7v1wsbfq75.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060723214524.GC20068@admingilde.org> (Martin Waitz's message of "Sun, 23 Jul 2006 23:45:25 +0200")
Martin Waitz <tali@admingilde.org> writes:
> We already have a "---" separator to end the commit log.
> But writing the cover letter after this separator looks strange.
> Now it is possible to put the cover letter and comments both before
> or after the commit log, as the author sees fit.
>
> Just put the commit log between lines starting with "+++" and "---".
>
> Signed-off-by: Martin Waitz <tali@admingilde.org>
I do not have problem with the implementation itself, but
* I always had an impression that cover letters are tolerated
not encouraged. In other words, as a good practice it would
be nice if necessary information is described in the commit
log messages themselves. Do we want to start encouraging the
cover letter with this patch?
* Has anybody ever used that "+++" as an auxiliary separator?
In other words, is it an established convention? If not,
would it be a good convention that we would want to establish
here?
next prev parent reply other threads:[~2006-07-24 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-23 21:45 [PATCH] support cover letter before commit log, using "+++" Martin Waitz
2006-07-24 6:54 ` Junio C Hamano [this message]
2006-07-24 7:04 ` Martin Waitz
2006-07-24 9:53 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1wsbfq75.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=tali@admingilde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).