From: Junio C Hamano <junkio@cox.net>
To: cel@citi.umich.edu
Cc: git@vger.kernel.org
Subject: Re: omitted test scripts?
Date: Mon, 19 Sep 2005 09:19:05 -0700 [thread overview]
Message-ID: <7v1x3lrpxi.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <432EDE3F.7070407@citi.umich.edu> (Chuck Lever's message of "Mon, 19 Sep 2005 11:50:23 -0400")
Chuck Lever <cel@citi.umich.edu> writes:
> i noticed while testing the new cache API that there are no tests under
> t/ for git-merge-index.
In the past, when I did any major butchering of existing code or
made nontrivial additions, I wrote test scripts to cover what
should happen (and what to be preserved) first to make sure the
changes or additions would not introduce regression. I think we
have been reasonably successful (Daniel could fill us in with
experiences with read-tree tests).
I have been expecting people to follow suit, without explicitly
asking them to do, so when I took over the project. Further I
got sloppy when accepting any sizable patches. Sorry about
that.
> there is also no test script that covers the prune_cache() function in
> ls-files.c.
That's one of the item on the TODO list and patches to extend
test coverage are always welcomed.
next prev parent reply other threads:[~2005-09-19 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-10 18:27 git-merge-cache / StGIT - gitmergeonefile.py: merging one tree into another rather than two trees into merge base Blaisorblade
2005-09-11 8:24 ` Catalin Marinas
2005-09-12 12:59 ` Chuck Lever
2005-09-14 17:46 ` Blaisorblade
2005-09-14 18:16 ` Blaisorblade
2005-09-14 18:19 ` Blaisorblade
2005-09-15 10:06 ` Catalin Marinas
2005-09-16 18:45 ` Blaisorblade
2005-09-16 19:59 ` Junio C Hamano
2005-09-17 9:31 ` Catalin Marinas
2005-09-19 15:50 ` omitted test scripts? Chuck Lever
2005-09-19 16:19 ` Junio C Hamano [this message]
2005-09-19 17:01 ` Daniel Barkalow
2005-09-19 18:54 ` Matthias Urlichs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1x3lrpxi.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=cel@citi.umich.edu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).