cogito testsuite failure

cogito testsuite failure

[Pavel Roskin]

Hello!

"make test" fails for current cogito:

*** t4008-diff-break-rewrite.sh ***
*   ok 1: setup
*   ok 2: change file1 with copy-edit of file0 and remove file0
*   ok 3: run diff with -B
*   ok 4: validate result of -B (#1)
*   ok 5: run diff with -B and -M
*   ok 6: validate result of -B -M (#2)
*   ok 7: swap file0 and file1
*   ok 8: run diff with -B
*   ok 9: validate result of -B (#3)
*   ok 10: run diff with -B and -M
*   ok 11: validate result of -B -M (#4)
*   ok 12: make file0 into something completely different
*   ok 13: run diff with -B
* FAIL 14: validate result of -B (#5) compare_diff_raw current expected
*   ok 15: run diff with -B
* FAIL 16: validate result of -B -M (#6) compare_diff_raw current expected
*   ok 17: run diff with -M
* FAIL 18: validate result of -M (#7) compare_diff_raw current expected
*   ok 19: file1 edited to look like file0 and file0 rename-edited to file2
*   ok 20: run diff with -B
*   ok 21: validate result of -B (#8)
*   ok 22: run diff with -B -M
*   ok 23: validate result of -B -M (#9)
* failed 3 among 23 test(s)

The failures happens because the test uses file ../README, which was
changed recently (and therefore, its checksum changed as well).  Also,
this and several other tests refer to ../COPYING, which is going to
change as well (it has an old mailing address of FSF).

I suggest that we use separate test files.  It would be great if those
files included text in several languages to test support for non-ASCII
symbols (maybe HELLO from emacs sources).

Or maybe we could use short files embedded in the scripts.  Or maybe we
could use sed to take significant portions of GPL that don't include
Linus' foreword, any mailing addresses or "19" when it's used as two
first digits of a year.

-- 
Regards,
Pavel Roskin

Re: cogito testsuite failure

[Junio C Hamano]

My intention was not to check the actual SHA1 in anything other
than t0000-basic.sh, but some test in t4000 series were buggy
and ended up comparing the SHA1.

I have since corrected them and I believe the test suite in the
current tip of Linus tree has the corrected compare_diff_raw and
friends in t/diff-lib.sh, which t4000 series use to avoid this
problem.  I just hand munged COPYING and README and ran t4008 in
the Linus tree, and do not see the problem you are reporting.

Could you verify that your test failure is coming from the
version that was before t/diff-lib.sh was introduced?  Otherwise
I have to investigate this further.

Re: cogito testsuite failure

[Pavel Roskin]

Hi, Junio!

On Tue, 2005-05-31 at 21:27 -0700, Junio C Hamano wrote:
> My intention was not to check the actual SHA1 in anything other
> than t0000-basic.sh, but some test in t4000 series were buggy
> and ended up comparing the SHA1.
> 
> I have since corrected them and I believe the test suite in the
> current tip of Linus tree has the corrected compare_diff_raw and
> friends in t/diff-lib.sh, which t4000 series use to avoid this
> problem.  I just hand munged COPYING and README and ran t4008 in
> the Linus tree, and do not see the problem you are reporting.
> 
> Could you verify that your test failure is coming from the
> version that was before t/diff-lib.sh was introduced?  Otherwise
> I have to investigate this further.

The failure in on the "cogito" branch
(rsync://rsync.kernel.org/pub/scm/cogito/cogito.git), which doesn't have
t/diff-lib.sh.

The "git" branch (rsync://www.kernel.org/pub/scm/git/git.git) is fine.
Sorry for the noise.  I should have checked that branch too.

-- 
Regards,
Pavel Roskin

Re: cogito testsuite failure

[Junio C Hamano]

>>>>> "PR" == Pavel Roskin <proski@gnu.org> writes:

PR> The failure in on the "cogito" branch
PR> (rsync://rsync.kernel.org/pub/scm/cogito/cogito.git), which doesn't have
PR> t/diff-lib.sh.

PR> The "git" branch (rsync://www.kernel.org/pub/scm/git/git.git) is fine.
PR> Sorry for the noise.  I should have checked that branch too.

No problem.  Thanks.