git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-clone.txt: remove the restriction on pushing from a shallow clone
Date: Thu, 11 Jul 2013 22:53:32 -0700	[thread overview]
Message-ID: <7v38rkpbmr.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1373607462-12836-1-git-send-email-pclouds@gmail.com> ("Nguyễn	Thái Ngọc Duy"'s message of "Fri, 12 Jul 2013 12:37:42 +0700")

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> The document says one cannot push from a shallow clone. But that is
> not true (maybe it was at some point in the past). The client does not
> stop such a push nor does it give any indication to the receiver that
> this is a shallow push. If the receiver accepts it, it's in.
>
> Since 52fed6e (receive-pack: check connectivity before concluding "git
> push" - 2011-09-02), receive-pack is prepared to deal with broken
> push, a shallow push can't cause any corruption. Update the document
> to reflect that.

Err, what are these lines in builtin/receive-pack.c doing, then?

        int cmd_receive_pack(int argc, const char **argv, const char *prefix)
        {
                ...
                setup_path();

                if (!enter_repo(dir, 0))
                        die("'%s' does not appear to be a git repository", dir);

                if (is_repository_shallow())
                        die("attempt to push into a shallow repository");
                ...

  reply	other threads:[~2013-07-12  5:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-12  5:37 [PATCH] git-clone.txt: remove the restriction on pushing from a shallow clone Nguyễn Thái Ngọc Duy
2013-07-12  5:53 ` Junio C Hamano [this message]
2013-07-12  5:54 ` Junio C Hamano
2013-07-12  7:54   ` Duy Nguyen
2013-07-13 21:25 ` Jonathan Nieder
2013-07-14  2:28   ` Duy Nguyen
2013-07-14 18:52     ` Junio C Hamano
2013-07-15  1:01       ` Duy Nguyen
2013-07-15  6:33         ` Duy Nguyen
2013-07-15 15:31           ` Junio C Hamano
2013-07-15 15:35           ` [PATCH] Revert "git-clone.txt: remove the restriction on pushing from a shallow clone" Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v38rkpbmr.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).