From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 6/6] sparse: Fix mingw_main() argument number/type errors
Date: Sun, 28 Apr 2013 12:31:11 -0700 [thread overview]
Message-ID: <7v38uaqwow.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <517C6DEF.2050305@lsrfire.ath.cx> ("René Scharfe"'s message of "Sun, 28 Apr 2013 02:31:43 +0200")
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> Why not take the opposite direction with a patch like this?
> ...
> diff --git a/compat/mingw.h b/compat/mingw.h
> index 389ae01..74e7b87 100644
> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> @@ -452,11 +452,11 @@ int xwcstoutf(char *utf, const wchar_t *wcs, size_t utflen);
>
> void mingw_startup();
> #define main(c,v) dummy_decl_mingw_main(); \
> -static int mingw_main(); \
> +static int mingw_main(int, const char **); \
> int main(int argc, const char **argv) \
But traditionally main is declared like
int main(int argc, char *argv[]);
without const, no?
next prev parent reply other threads:[~2013-04-28 19:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 19:19 [PATCH 6/6] sparse: Fix mingw_main() argument number/type errors Ramsay Jones
2013-04-28 0:31 ` René Scharfe
2013-04-28 19:31 ` Junio C Hamano [this message]
2013-04-29 16:10 ` René Scharfe
2013-04-29 23:30 ` Ramsay Jones
2013-04-29 21:52 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v38uaqwow.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).