From: Junio C Hamano <gitster@pobox.com>
To: 徐迪 <xudifsd@gmail.com>
Cc: "Git 邮件列表" <git@vger.kernel.org>
Subject: Re: [PATCH] strbuf: move strbuf_readline_fd() from bundle.c to strbuf.{c,h}
Date: Sun, 12 Feb 2012 09:07:48 -0800 [thread overview]
Message-ID: <7v39agkmjf.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAMocUqSefruci_ueWHUH6rqz8VFcakHErq8QV_bvghWMyHKVJg@mail.gmail.com> ("徐迪"'s message of "Sun, 12 Feb 2012 20:25:15 +0800")
徐迪 <xudifsd@gmail.com> writes:
> Shouldn't I supposed to receive any information about this patch?
Not necessarily X-<.
Things can get lost in the noise, and sending a reminder message like you
just did, after waiting for a few to several days, is considered a good
practice.
> Has it accepted or not?
Anything and everything being considered for inclusion is reachable from
the tip of the 'next' branch; other patches that might turn out to be of
value, or ones that at least deserve more sets of eyeballs, are only in
the 'pu' branch.
> If not what wrong with this patch?
That is not a valid question to ask.
We do not apply a patch merely because it is _not wrong_. It must be
clear why it is a good thing for the project to apply the patch.
Your patch in question is barely a day old and I didn't have a chance to
look at it, and I do not think other volunteer reviewers did, either, so
I don't know if it is wrong or it has merit yet.
next prev parent reply other threads:[~2012-02-12 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 9:50 [PATCH] strbuf: move strbuf_readline_fd() from bundle.c to strbuf.{c,h} 徐迪
2012-02-12 12:25 ` 徐迪
2012-02-12 17:07 ` Junio C Hamano [this message]
2012-02-13 3:54 ` 徐迪
2012-02-12 17:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v39agkmjf.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=xudifsd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox