From: Junio C Hamano <gitster@pobox.com>
To: James Pickens <jepicken@gmail.com>
Cc: Git ML <git@vger.kernel.org>
Subject: Re: 'git status' on NFS performance regression in 1.7.0
Date: Wed, 17 Feb 2010 12:22:49 -0800 [thread overview]
Message-ID: <7v3a0zmx2e.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <885649361002171208j41405b9exdfc34034c905e96c@mail.gmail.com> (James Pickens's message of "Wed\, 17 Feb 2010 13\:08\:12 -0700")
James Pickens <jepicken@gmail.com> writes:
> I noticed that 'git status' in version 1.7.0 is much slower than in 1.6.2.5
> on large work trees on NFS - averaging ~13 seconds runtime vs. ~2 seconds.
> I did a bit of debugging and found that 'git status' apparently doesn't use
> the multi-threaded preload_index any more, although some other commands
> like diff still use it. Was it intentionally dropped from 'git status'?
There might be subtle breakage for doing this, but it would be worth a try
;-)
builtin-commit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-commit.c b/builtin-commit.c
index 55676fd..71f81c9 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -1046,7 +1046,7 @@ int cmd_status(int argc, const char **argv, const char *prefix)
if (*argv)
s.pathspec = get_pathspec(prefix, argv);
- read_cache();
+ read_cache_preload();
refresh_index(&the_index, REFRESH_QUIET|REFRESH_UNMERGED, s.pathspec, NULL, NULL);
s.is_initial = get_sha1(s.reference, sha1) ? 1 : 0;
s.in_merge = in_merge;
next prev parent reply other threads:[~2010-02-17 20:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 20:08 'git status' on NFS performance regression in 1.7.0 James Pickens
2010-02-17 20:22 ` Junio C Hamano [this message]
2010-02-17 20:23 ` Junio C Hamano
2010-02-17 21:35 ` James Pickens
2010-02-17 22:03 ` Junio C Hamano
2010-02-18 8:46 ` Peter Krefting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3a0zmx2e.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jepicken@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).