From: Junio C Hamano <gitster@pobox.com>
To: Stephen Boyd <bebarino@gmail.com>
Cc: git@vger.kernel.org, Thomas Adam <thomas.adam22@gmail.com>,
Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [PATCHv3 3/4] submodule, repack: migrate to git-sh-setup's say()
Date: Mon, 15 Jun 2009 23:18:37 -0700 [thread overview]
Message-ID: <7v3aa0g0qq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7viqiwg1rl.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon\, 15 Jun 2009 22\:56\:30 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> ...
> If the convention is "GIT_QUIET, when set to non-empty string, squelches
> the output", then I think the callers should be more consistent and the
> call to prune-packed should say something like this, which is admittedly a
> roundabout way:
>
> git prune-packed ${GIT_QUIET:+-q}
>
> for consistency (and then what you set to GIT_QUIET in the first hunk I
> quoted does not matter anymore---it can even be t or 1 or whatever).
>
> I think this does not matter too much, because I suspect that in the
> longer term scripted Porcelains are going away, but still...
What I meant was that my _style_ comment does not matter too much. The
addition of "quiet" _is_ a worthwhile thing to do, I think.
next prev parent reply other threads:[~2009-06-16 6:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 2:05 [PATCHv3 0/4] Teach shell scripts to be quiet Stephen Boyd
2009-06-16 2:05 ` [PATCHv3 1/4] t4150: test applying with a newline in subject Stephen Boyd
2009-06-16 2:05 ` [PATCHv3 2/4] git-sh-setup: introduce say() for quiet options Stephen Boyd
2009-06-16 2:05 ` [PATCHv3 3/4] submodule, repack: migrate to git-sh-setup's say() Stephen Boyd
2009-06-16 2:05 ` [PATCHv3 4/4] am, rebase: teach quiet option Stephen Boyd
2009-06-16 5:57 ` Junio C Hamano
2009-06-16 7:50 ` Stephen Boyd
2009-06-16 5:56 ` [PATCHv3 3/4] submodule, repack: migrate to git-sh-setup's say() Junio C Hamano
2009-06-16 6:18 ` Junio C Hamano [this message]
2009-06-16 7:38 ` Stephen Boyd
2009-06-16 8:13 ` [PATCHv3 2/4] git-sh-setup: introduce say() for quiet options Johannes Sixt
2009-06-16 22:32 ` [PATCHv4 0/5] Teach shell scripts to be quiet Stephen Boyd
2009-06-16 22:32 ` [PATCHv4 1/5] t4150: test applying with a newline in subject Stephen Boyd
2009-06-16 22:32 ` [PATCHv4 2/5] am: suppress apply errors when using 3-way Stephen Boyd
2009-06-16 22:32 ` [PATCHv4 3/5] git-sh-setup: introduce say() for quiet options Stephen Boyd
2009-06-16 22:33 ` [PATCHv4 4/5] submodule, repack: migrate to git-sh-setup's say() Stephen Boyd
2009-06-16 22:33 ` [PATCHv4 5/5] am, rebase: teach quiet option Stephen Boyd
2009-06-18 1:07 ` [PATCHv4 6/5] stash: " Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3aa0g0qq.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=thomas.adam22@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).