From: Junio C Hamano <gitster@pobox.com>
To: Erik Broes <erikbroes@ripe.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-shell: Add 'git-upload-archive' to allowed commands.
Date: Sat, 11 Apr 2009 12:22:54 -0700 [thread overview]
Message-ID: <7v3acff10x.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 49DE537C.8070907@ripe.net
Erik Broes <erikbroes@ripe.net> writes:
> This allows for example gitosis to allow use of 'git archive --remote' in a
> controlled environment.
>
> Signed-off-by: Erik Broes <erikbroes@ripe.net>
> ---
>
> There were some questions on IRC raising (valid) concerns about security.
> If there is a dangling commit on the remote end and any user would know
> or guess the SHA, it could be retrieved where git-upload-pack will not
> allow so.
>
> We were unable to find out if this was the original reason git-shell was
> never extended with git-upload-archive functionality or if it was a simple
> oversight. If it was the reason I'm not sure there is an easy way out.
Can't the "security concern" be addressed by whatever creates the
controlled environment (e.g. gitosis)? For example, git-daemon can be
configured to service upload-archive request, so I do not think it is such
a bad idea to make this available if the site owner wants to use it.
next prev parent reply other threads:[~2009-04-11 19:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 19:58 [PATCH] git-shell: Add 'git-upload-archive' to allowed commands Erik Broes
2009-04-11 19:22 ` Junio C Hamano [this message]
2009-04-12 14:07 ` Erik Broes
2009-04-14 6:09 ` Björn Steinbrink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3acff10x.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=erikbroes@ripe.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).