From: Junio C Hamano <gitster@pobox.com>
To: "George Spelvin" <linux@horizon.com>
Cc: git@vger.kernel.org
Subject: Re: [WARNING] Proposed future changes that are backward incompatible
Date: Fri, 27 Feb 2009 11:59:32 -0800 [thread overview]
Message-ID: <7v3adzk5wb.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090227192708.6266.qmail@science.horizon.com> (George Spelvin's message of "Fri, 27 Feb 2009 14:27:08 -0500")
"George Spelvin" <linux@horizon.com> writes:
> There's one more change that was suggested that I'd like to propose:
> - Make "git grep" search the whole repository by default; include an
> explicit "." path limiter to search only the current directory.
>
> In addition to being more consistent with other commands like "git log",
> this saves a lot of typing working in drivers/net/usb/ if the identifier
> you're looking for is in include/. Typing the additional space-dot
> is pretty trivial if you want the current directory only.
I do not remember it was ever suggested, let alone coming to anything near
consensus.
The only way you could justify such a default change is to say:
Almost all the time, everybody wants to use this new behaviour; the
old behaviour is almost never useful in any situation other than a
narrow corner case; and if somebody wants to do such a useless thing
in a corner case, he can always add " ." at the end, so nothing is
lost.
I do not think that is true for the change you are proposing here. 'He
can always add " ." at the end' alone is not a good enough justification.
I however think your use case deserves to be supported, and I would not
mind at all accepting a new "--full-tree" (or some shorter synonym) option
if the patch is cleanly done (hint, hint).
I'd rather not add this to "future changes that are backward incompatible"
list. It may be a useful new feature, but that is not what the topic of
this thread is about.
next prev parent reply other threads:[~2009-02-27 20:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 19:27 [WARNING] Proposed future changes that are backward incompatible George Spelvin
2009-02-27 19:42 ` Nicolas Pitre
2009-02-27 19:51 ` Sverre Rabbelier
2009-02-27 19:48 ` Johannes Schindelin
2009-02-27 20:54 ` Pascal Obry
2009-02-27 19:59 ` Junio C Hamano [this message]
2009-02-27 20:31 ` George Spelvin
2009-02-27 21:02 ` Junio C Hamano
2009-02-28 2:36 ` Markus Heidelberg
-- strict thread matches above, loose matches on Subject: below --
2009-02-26 1:28 Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3adzk5wb.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=linux@horizon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).