From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: eletuchy@gmail.com, gitster@pobox.com, git@vger.kernel.org,
Eugene Letuchy <eugene@facebook.com>
Subject: Re: [PATCH 1/2] Make git blame's date output format configurable, like git log
Date: Mon, 23 Feb 2009 08:33:47 -0800 [thread overview]
Message-ID: <7v3ae5un84.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20090222230358.GA19011@coredump.intra.peff.net
Jeff King <peff@peff.net> writes:
> On Fri, Feb 20, 2009 at 02:51:11PM -0800, eletuchy@gmail.com wrote:
>
>> @@ -1975,6 +1975,9 @@ static int git_blame_config(const char *var, const char *value, void *cb)
>> blank_boundary = git_config_bool(var, value);
>> return 0;
>> }
>> + if (!strcmp(var, "blame.date") && value[0]) {
>> + blame_date_mode = parse_date_format(value);
>> + }
>> return git_default_config(var, value, cb);
>> }
>
> When there is a config value we are expecting to have a value rather
> than a boolean, we usually print an error rather than silently
> discarding.
Oops, missed that. Yes, this needs fixing.
Thanks.
next prev parent reply other threads:[~2009-02-23 16:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 22:51 [PATCH 1/2] Make git blame's date output format configurable, like git log eletuchy
2009-02-22 17:23 ` Junio C Hamano
2009-02-22 23:03 ` Jeff King
2009-02-23 9:09 ` Eugene Letuchy
2009-02-24 5:00 ` Jeff King
2009-02-23 16:33 ` Junio C Hamano [this message]
[not found] <[PATCH] Make git blame date output format configurable, a la git log>
2009-02-20 21:23 ` [PATCH] Make git blame date output format configurable, a la git log (take 2) eletuchy
2009-02-20 21:23 ` [PATCH 1/2] Make git blame's date output format configurable, like git log eletuchy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3ae5un84.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=eletuchy@gmail.com \
--cc=eugene@facebook.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).