From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Gerrit Pape <pape@smarden.org>
Subject: Re: [PATCH v2 1/8] config: Trivial rename in preparation for parseopt.
Date: Mon, 16 Feb 2009 17:45:00 -0800 [thread overview]
Message-ID: <7v3aedet0j.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1234832094-15541-1-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Tue, 17 Feb 2009 02:54:47 +0200")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> When using the --list option general errors where not properly reported,
> only errors related with the 'file'. Now they are reported, and 'file'
> is irrelevant.
> ...
> @@ -299,10 +300,8 @@ int cmd_config(int argc, const char **argv, const char *prefix)
> else if (!strcmp(argv[1], "--list") || !strcmp(argv[1], "-l")) {
> if (argc != 2)
> usage(git_config_set_usage);
> - if (git_config(show_all_config, NULL) < 0 &&
> - file && errno)
> - die("unable to read config file %s: %s", file,
> - strerror(errno));
> + if (git_config(show_all_config, NULL) < 0)
> + die("error processing config file(s)");
Does the author of 93a56c2 (git-config: print error message if the config
file cannot be read, 2007-10-12) have any comment on this change (cc:ed)?
next prev parent reply other threads:[~2009-02-17 1:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 0:54 [PATCH v2 1/8] config: Trivial rename in preparation for parseopt Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 2/8] config: Reorganize get_color* Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 3/8] config: Use parseopt Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 4/8] config: Disallow multiple variable types Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 5/8] config: Disallow multiple config file locations Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 6/8] config: Don't allow extra arguments for -e or -l Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 7/8] config: Codestyle cleanups Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 8/8] config: Cleanup editor action Felipe Contreras
2009-02-17 2:28 ` Junio C Hamano
2009-02-17 2:24 ` [PATCH v2 4/8] config: Disallow multiple variable types Junio C Hamano
2009-02-17 2:24 ` [PATCH v2 3/8] config: Use parseopt Junio C Hamano
2009-02-17 13:55 ` Felipe Contreras
2009-02-17 5:44 ` Junio C Hamano
2009-02-17 10:35 ` Felipe Contreras
2009-02-17 11:55 ` Johannes Schindelin
2009-02-17 13:21 ` Felipe Contreras
2009-02-17 1:00 ` [PATCH v2 2/8] config: Reorganize get_color* Felipe Contreras
2009-02-17 2:24 ` Junio C Hamano
2009-02-17 1:45 ` Junio C Hamano [this message]
2009-02-17 2:42 ` [PATCH v2 1/8] config: Trivial rename in preparation for parseopt Felipe Contreras
2009-02-17 12:01 ` Johannes Schindelin
2009-02-17 13:59 ` Felipe Contreras
2009-02-17 9:00 ` Gerrit Pape
2009-02-17 11:58 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3aedet0j.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).