From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Tor Arne Vestbø" <tavestbo@trolltech.com>, git@vger.kernel.org
Subject: Re: [PATCH next] git-notes: fix printing of multi-line notes
Date: Tue, 13 Jan 2009 22:48:17 -0800 [thread overview]
Message-ID: <7v3afm758u.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0901132339270.3586@pacific.mpi-cbg.de> (Johannes Schindelin's message of "Tue, 13 Jan 2009 23:40:14 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Tue, 13 Jan 2009, Tor Arne Vestbø wrote:
>
>> The line length was read from the same position every time,
>> causing mangled output when printing notes with multiple lines.
>>
>> Also, adding new-line manually for each line ensures that we
>> get a new-line between commits, matching git-log for commits
>> without notes.
>>
>> Signed-off-by: Tor Arne Vestbø <tavestbo@trolltech.com>
>> ---
>
> Patch looks good, so
>
> Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> For extra browny points, you could add a test with multi-line notes.
Yeah, not just "extra", having tests is a good way to make sure a new
feature like this evolves healthily.
Tor?
next prev parent reply other threads:[~2009-01-14 6:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 19:57 [PATCH next] git-notes: fix printing of multi-line notes Tor Arne Vestbø
2009-01-13 22:40 ` Johannes Schindelin
2009-01-14 6:48 ` Junio C Hamano [this message]
2009-01-14 10:14 ` Johannes Schindelin
2009-01-14 14:39 ` [PATCH next] git-notes: add test case for " Tor Arne Vestbø
2009-01-14 15:34 ` Johannes Schindelin
2009-01-14 16:28 ` [PATCH next v2] " Tor Arne Vestbø
2009-01-14 16:56 ` Jeff King
2009-01-14 17:09 ` Boyd Stephen Smith Jr.
2009-01-14 17:13 ` Jeff King
2009-01-14 17:14 ` Johannes Sixt
2009-01-14 17:19 ` Jeff King
2009-01-14 18:01 ` Johannes Schindelin
2009-01-14 20:57 ` [PATCH next v3] " Tor Arne Vestbø
2009-01-14 21:10 ` Johannes Schindelin
2009-01-16 13:06 ` [PATCH next v4] git-notes: fix printing of " Tor Arne Vestbø
2009-01-18 21:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3afm758u.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=tavestbo@trolltech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).