From: Junio C Hamano <gitster@pobox.com>
To: Matt Kraai <kraai@ftbfs.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-send-email: handle email address with quoted comma
Date: Sat, 20 Dec 2008 12:09:44 -0800 [thread overview]
Message-ID: <7v3agiwquv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: loom.20081219T162504-25@post.gmane.org
Matt Kraai <kraai@ftbfs.org> writes:
> Howdy,
>
> Wu Fengguang <fengguang.wu <at> intel.com> writes:
>> +sub split_addrs {
>> + return parse_line('\s*,\s*', 1, @_);
>> +}
>> +
>
> I'm not sure it's still a good idea to use parse_line. It should work OK for
> now, since split_addrs is only passed one string. If anyone ever tries to pass
> it a list of strings, however, parse_line will ignore all but the first.
Yikes, I should have caught this. As you point out, this is a breakage
waiting to happen until somebody restructures the callers. We should
futureproof it by using quotewords() instead.
next prev parent reply other threads:[~2008-12-20 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 3:40 [PATCH] git-send-email: handle email address with quoted comma Wu Fengguang
2008-12-19 6:40 ` Junio C Hamano
2008-12-19 8:10 ` Wu Fengguang
2008-12-19 16:28 ` Matt Kraai
2008-12-20 20:09 ` Junio C Hamano [this message]
2008-12-20 6:48 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2008-12-19 6:38 Matt Kraai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3agiwquv.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kraai@ftbfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).