git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: markus.heidelberg@web.de
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation: fix typos, grammar, asciidoc syntax
Date: Fri, 19 Dec 2008 22:48:42 -0800	[thread overview]
Message-ID: <7v3agj1gvp.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 200812191314.19302.markus.heidelberg@web.de

Markus Heidelberg <markus.heidelberg@web.de> writes:

> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> ---
>  Documentation/diff-format.txt         |    2 +-
>  Documentation/diff-generate-patch.txt |    6 +++---
>  Documentation/git-commit.txt          |    2 +-
>  Documentation/git-diff-tree.txt       |    4 ++--
>  Documentation/git-mailinfo.txt        |    2 +-
>  Documentation/git-receive-pack.txt    |    4 ++--
>  Documentation/git-reflog.txt          |    4 ++--
>  Documentation/git-show-branch.txt     |    4 ++--
>  Documentation/git-submodule.txt       |    2 +-
>  Documentation/git-update-index.txt    |    8 ++++----
>  Documentation/gitcore-tutorial.txt    |    8 ++++----
>  Documentation/gitk.txt                |    4 ++--
>  Documentation/i18n.txt                |    4 ++--
>  13 files changed, 27 insertions(+), 27 deletions(-)

Whew, quite a lot of typos there are.

> @@ -172,7 +172,7 @@ only the primary branches.  In addition, if you happen to be on
>  your topic branch, it is shown as well.
>  
>  ------------
> -$ git show-branch --reflog='10,1 hour ago' --list master
> +$ git show-branch --reflog="10,1 hour ago" --list master
>  ------------

Is this just a personal taste, or a correction to typography?

Other than this one, I did not find anything else in your patch that
looked iffy.  Thanks for lending a good set of eyeballs.

  reply	other threads:[~2008-12-20  6:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-19 12:14 [PATCH] Documentation: fix typos, grammar, asciidoc syntax Markus Heidelberg
2008-12-20  6:48 ` Junio C Hamano [this message]
2008-12-20 13:18   ` Markus Heidelberg
2008-12-20 20:08     ` Junio C Hamano
2008-12-20 20:39       ` Teemu Likonen
2008-12-20 21:02         ` Markus Heidelberg
2008-12-20 21:18         ` Teemu Likonen
2008-12-20 21:13       ` Markus Heidelberg
2008-12-20 21:37         ` Teemu Likonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v3agj1gvp.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=markus.heidelberg@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).