From: Junio C Hamano <gitster@pobox.com>
To: Matt Kraai <kraai@ftbfs.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: unify boolean feature subroutines
Date: Mon, 15 Dec 2008 14:21:13 -0800 [thread overview]
Message-ID: <7v3agpw04m.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1229352709-4663-2-git-send-email-kraai@ftbfs.org> (Matt Kraai's message of "Mon, 15 Dec 2008 06:51:49 -0800")
Matt Kraai <kraai@ftbfs.org> writes:
> The boolean feature subroutines were identical except for the name of
> the configuration option, so make that a parameter and unify them.
I think this makes sense but unfortunately it comes after the other one
that I do not know what its point is...
next prev parent reply other threads:[~2008-12-15 22:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 14:51 [PATCH] gitweb: make feature_blame return a list Matt Kraai
2008-12-15 14:51 ` [PATCH] gitweb: unify boolean feature subroutines Matt Kraai
2008-12-15 22:21 ` Junio C Hamano [this message]
2008-12-15 22:20 ` [PATCH] gitweb: make feature_blame return a list Junio C Hamano
2008-12-15 22:52 ` Giuseppe Bilotta
2008-12-16 2:46 ` Matt Kraai
2008-12-16 5:38 ` Junio C Hamano
2008-12-16 6:16 ` [PATCH] gitweb: unify boolean feature subroutines Matt Kraai
2008-12-16 7:36 ` [PATCH] gitweb: pass the option name to the feature callback Matt Kraai
2008-12-16 9:03 ` [PATCH] gitweb: unify boolean feature subroutines Junio C Hamano
2008-12-16 14:23 ` Matt Kraai
2008-12-17 8:10 ` Petr Baudis
2008-12-17 8:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3agpw04m.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kraai@ftbfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).