From: Junio C Hamano <gitster@pobox.com>
To: Gustaf Hendeby <hendeby@isy.liu.se>
Cc: Christian Couder <chriscool@tuxfamily.org>, git@vger.kernel.org
Subject: Re: [PATCH] Avoid warning when bisecting a merge
Date: Fri, 05 Sep 2008 01:31:02 -0700 [thread overview]
Message-ID: <7v3akfvvsp.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <48C0DD32.5010008@isy.liu.se> (Gustaf Hendeby's message of "Fri, 05 Sep 2008 09:18:10 +0200")
Gustaf Hendeby <hendeby@isy.liu.se> writes:
> On 09/05/2008 08:29 AM, Junio C Hamano wrote:
> ...
>> Yup, that might make more sense. In the meantime, I suspect this makes
>> more sense than introducing a new state "0".
>
> I can't argue with that. Junio, your suggestion makes more sense. I
> should have paid more attention to what I was doing. Sorry about the noise.
That's Ok. Spotting mistakes is an important part of the review process;
there is no need to be afraid of or apologetic about it.
prev parent reply other threads:[~2008-09-05 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 21:02 [PATCH] Avoid warning when bisecting a merge Gustaf Hendeby
2008-09-05 6:14 ` Christian Couder
2008-09-05 6:29 ` Junio C Hamano
2008-09-05 7:18 ` Gustaf Hendeby
2008-09-05 8:31 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3akfvvsp.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=hendeby@isy.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).