From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Stephan Beyer <s-beyer@gmx.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] t/test-lib.sh: Let test_must_fail fail on signals only
Date: Wed, 16 Jul 2008 22:38:45 -0700 [thread overview]
Message-ID: <7v3am9m5ne.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080717051833.GA3100@sigio.intra.peff.net> (Jeff King's message of "Thu, 17 Jul 2008 01:18:34 -0400")
Jeff King <peff@peff.net> writes:
> On Tue, Jul 15, 2008 at 10:54:25PM -0700, Junio C Hamano wrote:
>
>> Anything that returns error() from its cmd_xxx() routine, for example,
>> would end up exiting with (-1). Is it "such bogus" error codes, though?
>
> I think it is bogus, because it is being implicitly truncated to an
> unsigned 8-bit value (at least on Linux -- I have no idea what other
> platforms do).
"Only the least significant 8 bits (that is, status & 0377) shall be
available to a waiting parent process". So it is not just "at least on
Linux" but is a well defined behaviour.
http://www.opengroup.org/onlinepubs/000095399/functions/exit.html
I would however agree that when we do mean 255 we should probably write
255, not (-1). It is easier to document things that way.
next prev parent reply other threads:[~2008-07-17 5:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-12 15:47 [PATCH 1/2] t/test-lib.sh: Let test_must_fail fail on signals only Stephan Beyer
2008-07-12 15:47 ` [PATCH 2/2] t/: Use "test_must_fail git" instead of "! git" Stephan Beyer
2008-07-12 16:04 ` Jakub Narebski
2008-07-12 21:43 ` Stephan Beyer
2008-07-12 21:30 ` [SQUASH PATCH] t9001: " Stephan Beyer
2008-07-16 5:18 ` [PATCH 1/2] t/test-lib.sh: Let test_must_fail fail on signals only Jeff King
2008-07-16 5:54 ` Junio C Hamano
2008-07-17 5:18 ` Jeff King
2008-07-17 5:38 ` Junio C Hamano [this message]
2008-07-17 6:01 ` Jeff King
2008-07-17 6:31 ` Junio C Hamano
2008-07-17 6:38 ` Jeff King
2008-07-17 7:22 ` Johannes Sixt
2008-07-17 7:25 ` Junio C Hamano
2008-07-16 11:57 ` Stephan Beyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3am9m5ne.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=s-beyer@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).