From: Junio C Hamano <gitster@pobox.com>
To: Robert Shearman <robertshearman@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.
Date: Tue, 08 Jul 2008 18:15:32 -0700 [thread overview]
Message-ID: <7v3amjq2mj.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1215555496-21335-1-git-send-email-robertshearman@gmail.com
Robert Shearman <robertshearman@gmail.com> writes:
> Call setup_git_directory_gently to allow git-imap-send to be used from subdirectories of a git tree.
> ---
> imap-send.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/imap-send.c b/imap-send.c
> index 1ec1310..89a1532 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1296,6 +1296,7 @@ main(int argc, char **argv)
> /* init the random number generator */
> arc4_init();
>
> + setup_git_directory_gently( NULL );
> git_config(git_imap_config, NULL);
>
> if (!imap_folder) {
I thought Jeff already explained why this NULL was a bad idea, but perhaps
I was dreaming...
Besides, the extra spaces around the argument is very distracting.
next prev parent reply other threads:[~2008-07-09 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 22:18 [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree Robert Shearman
2008-07-09 1:15 ` Junio C Hamano [this message]
2008-07-09 1:28 ` Jay Soffian
2008-07-09 12:08 ` Rob Shearman
-- strict thread matches above, loose matches on Subject: below --
2008-07-09 21:28 Robert Shearman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3amjq2mj.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=robertshearman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).