From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <junio@pobox.com>
Subject: Re: [PATCH] Add a test for git-add --ignore-errors
Date: Mon, 12 May 2008 20:48:22 -0700
Message-ID: <7v3aomx3sp.fsf@gitster.siamese.dyndns.org>
References: <47C95E34.1050306@dirk.my1.cc> <20080302154154.GC2973@steel.home>
 <20080302154238.GD2973@steel.home>
 <alpine.LSU.1.00.0803021555500.22527@racer.site>
 <7vtzjpoye6.fsf@gitster.siamese.dyndns.org>
 <20080512175654.GB3128@steel.home> <20080512175745.GC3128@steel.home>
 <20080512175810.GD3128@steel.home> <20080512175829.GE3128@steel.home>
 <20080512175848.GF3128@steel.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Git Mailing List <git@vger.kernel.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Dirk =?utf-8?Q?S=C3=BCsserott?= <newsletter@dirk.my1.cc>
To: Alex Riesen <raa.lkml@gmail.com>
X-From: git-owner@vger.kernel.org Tue May 13 05:49:32 2008
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1JvlW3-0004Li-4H
	for gcvg-git-2@gmane.org; Tue, 13 May 2008 05:49:27 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755663AbYEMDsg (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Mon, 12 May 2008 23:48:36 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755596AbYEMDsf
	(ORCPT <rfc822;git-outgoing>); Mon, 12 May 2008 23:48:35 -0400
Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:43957 "EHLO
	sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755037AbYEMDsf (ORCPT <rfc822;git@vger.kernel.org>);
	Mon, 12 May 2008 23:48:35 -0400
Received: from localhost.localdomain (localhost [127.0.0.1])
	by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 083D73458;
	Mon, 12 May 2008 23:48:33 -0400 (EDT)
Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client
 certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with
 ESMTP id 1F6F33457; Mon, 12 May 2008 23:48:27 -0400 (EDT)
In-Reply-To: <20080512175848.GF3128@steel.home> (Alex Riesen's message of
 "Mon, 12 May 2008 19:58:48 +0200")
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
X-Pobox-Relay-ID: 75432452-209F-11DD-B9D7-80001473D85F-77302942!a-sasl-fastnet.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/81984>

Alex Riesen <raa.lkml@gmail.com> writes:

> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
>  t/t3700-add.sh |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/t/t3700-add.sh b/t/t3700-add.sh
> index 287e058..ca3e33d 100755
> --- a/t/t3700-add.sh
> +++ b/t/t3700-add.sh
> @@ -179,4 +179,13 @@ test_expect_success 'git add --refresh' '
>  	test -z "`git diff-index HEAD -- foo`"
>  '
>  
> +test_expect_success 'git add --ignore-errors' '
> +	git reset --hard &&
> +	date >foo1 &&
> +	date >foo2 &&
> +	chmod 0 foo2 &&
> +	git add --verbose --ignore-errors .
> +	git ls-files |grep foo1
> +'
> +
>  test_done

I like the fact that you added --ignore-errors and made it still error out
when it cannot read some files.  Shouldn't we be testing it here with
"must-fail"?