git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: nanako3@bluebottle.com, git@vger.kernel.org
Subject: Re: [PATCH] git show documentation: no longer refer to git-diff-tree options
Date: Sun, 27 Apr 2008 10:33:26 -0700	[thread overview]
Message-ID: <7v3ap7gq3d.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20080427114504.GT4012@genesis.frugalware.org

Miklos Vajna <vmiklos@frugalware.org> writes:

> I just checked each option one by one and right, I haven't found any
> other option that could be useful for git-show either. Given that the
> wording of -s for git-show is quite different, I think it would be
> easier to just document -s in git-show as well. Like this?

Hmm, yes but not exactly.

You lost --stat, --name-only and friends that were implied by mentioning
"diff-tree".

I agree your _motivation_ behind your original patch is good.  Saying "see
also that page if you want to do very exotic and rarely useful operation"
is one thing, but saying "described are most often used ones" and not
describing enough is bad.

Perhaps we would want to include diff-options.txt.  There may be some
options that are no-op or always-on in the context of "git show" in the
file, but we already have an infrastracture to turn parts of the inclusion
on and off depending on which manual page includes it.

> diff --git a/Documentation/git-show.txt b/Documentation/git-show.txt
> index dccf0e2..299b611 100644
> --- a/Documentation/git-show.txt
> +++ b/Documentation/git-show.txt
> @@ -25,12 +25,6 @@ with \--name-only).
>  
>  For plain blobs, it shows the plain contents.
>  
> -The command takes options applicable to the linkgit:git-diff-tree[1] command to
> -control how the changes the commit introduces are shown.
> -
> -This manual page describes only the most frequently used options.
> -
> -
>  OPTIONS
>  -------
>  <object>::
> @@ -38,6 +32,9 @@ OPTIONS
>  	For a more complete list of ways to spell object names, see
>  	"SPECIFYING REVISIONS" section in linkgit:git-rev-parse[1].
>  
> +-s::
> +	Don't show a textural diff for commits.
> +
>  include::pretty-options.txt[]
>  
>  
> -- 
> 1.5.5.1.91.g499fc.dirty

  reply	other threads:[~2008-04-27 17:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26 21:01 [PATCH 1/2] Documentation: move options of git-diff-tree to a separate file Miklos Vajna
2008-04-26 21:01 ` [PATCH 2/2] Documentation: include diff-tree-options in git-show manpage Miklos Vajna
2008-04-27  0:24 ` [PATCH 1/2] Documentation: move options of git-diff-tree to a separate file Junio C Hamano
2008-04-27  2:17   ` [PATCH] " Miklos Vajna
2008-04-27  7:29   ` しらいしななこ
     [not found]   ` <200804270730.m3R7UTTp011092@mi1.bluebottle.com>
2008-04-27 11:45     ` [PATCH] git show documentation: no longer refer to git-diff-tree options Miklos Vajna
2008-04-27 17:33       ` Junio C Hamano [this message]
2008-05-11 22:37         ` Miklos Vajna
2008-05-12 23:10           ` Junio C Hamano
2008-05-13  9:11             ` Miklos Vajna
2008-05-13  9:16               ` Miklos Vajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v3ap7gq3d.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=nanako3@bluebottle.com \
    --cc=vmiklos@frugalware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).