From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Teemu Likonen <tlikonen@iki.fi>, git@vger.kernel.org
Subject: Re: BUG: "git add --interactive" does not work with UTF-8 filenames
Date: Wed, 02 Apr 2008 08:50:07 -0700 [thread overview]
Message-ID: <7v3aq49ryo.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200804021317.16007.jnareb@gmail.com> (Jakub Narebski's message of "Wed, 2 Apr 2008 12:17:14 +0100")
Jakub Narebski <jnareb@gmail.com> writes:
> By the way, the code to unwrap the path quoting can be found in gitweb
> as unescape() subroutine... or git-add--interactive can use '-z' switch.
Yes, but if you use '-z' to read from plumbing, you would need your own
wrapping on the UI side to protect your output from control characters
(most notably LF) embedded in pathnames.
Also I had an impression that the compatibility implementation of
run_cmd_pipe() had some issues with NUL terminated list.
next prev parent reply other threads:[~2008-04-02 15:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 19:32 BUG: "git add --interactive" does not work with UTF-8 filenames Teemu Likonen
2008-04-01 20:08 ` Jakub Narebski
2008-04-01 20:29 ` BUG: "git add --interactive" does not work with UTF-8 filenames if core.quotepath=true Teemu Likonen
2008-04-02 0:41 ` BUG: "git add --interactive" does not work with UTF-8 filenames Junio C Hamano
2008-04-02 11:17 ` Jakub Narebski
2008-04-02 15:50 ` Junio C Hamano [this message]
2008-04-02 17:06 ` [PATCH] Describe the bug about handling non-Ascii filenames in 'git add -i' Teemu Likonen
2008-04-02 17:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3aq49ryo.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=tlikonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).