From: Junio C Hamano <gitster@pobox.com>
To: Josh Elsasser <josh@elsasser.org>
Cc: git@vger.kernel.org, Frank Lichtenheld <frank@lichtenheld.de>
Subject: Re: [PATCH v3] Allow git-cvsserver database table name prefix to be specified.
Date: Thu, 27 Mar 2008 16:13:53 -0700 [thread overview]
Message-ID: <7v3aqbahfy.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <12066517343988-git-send-email-josh@elsasser.org> (Josh Elsasser's message of "Thu, 27 Mar 2008 14:02:14 -0700")
Josh Elsasser <josh@elsasser.org> writes:
> Adds a gitcvs.dbtablenameprefix config variable, the contents of which
> are prepended to any database tables names used by git-cvsserver. The
> same substutions as gitcvs.dbname and gitcvs.dbuser are supported, and
> any non-alphabetic characters are replaced with underscores.
>
> A typo found in contrib/completion/git-completion.bash is also fixed.
Wow, sharp eyes.
> This version of the patch is a bit cleaner, it calls a function to get
> the table names instead of pasting a variable reference everywhere.
Looks much cleaner then the previous one, indeed.
I consider it signed-off?
prev parent reply other threads:[~2008-03-27 23:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 5:05 [PATCH v2] Allow git-cvsserver database table name prefix to be specified Josh Elsasser
2008-03-20 5:36 ` Junio C Hamano
2008-03-27 20:57 ` Josh Elsasser
2008-03-27 21:02 ` [PATCH v3] " Josh Elsasser
2008-03-27 22:35 ` Johannes Schindelin
2008-03-27 23:13 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3aqbahfy.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=frank@lichtenheld.de \
--cc=git@vger.kernel.org \
--cc=josh@elsasser.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).