From: Junio C Hamano <gitster@pobox.com>
To: "Ping Yin" <pkufranky@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 2/4] git-submodule: New subcommand 'summary' (2) - show commit summary
Date: Wed, 05 Mar 2008 20:10:24 -0800 [thread overview]
Message-ID: <7v3ar4lcgf.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <46dff0320803051816x5b957da0m6396d31cad8b4116@mail.gmail.com> (Ping Yin's message of "Thu, 6 Mar 2008 10:16:23 +0800")
"Ping Yin" <pkufranky@gmail.com> writes:
> ... I think showing 2 (the head and tail one) should make more sense
> since the head one would be "Initial add ..." in many cases which
> doesn't make much sense for the user.
Why would you want to see the bottom one? I still don't understand.
And I do not mean this as a rhetorical question. I am here to learn and
I would like to make sure that I do not make a suggestion based on wrong
understanding of what the user wants to see.
I probably am lacking imagination to think of a good use scenario that
showing the bottom one would be useful to the user, and you as the author
of this patch must thought about what the user want much more than me.
next prev parent reply other threads:[~2008-03-06 4:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-02 18:15 [PATCH v3 1/4] git-submodule: New subcommand 'summary' (1) - code framework Ping Yin
2008-03-02 18:15 ` [PATCH v3 2/4] git-submodule: New subcommand 'summary' (2) - show commit summary Ping Yin
2008-03-05 23:57 ` Junio C Hamano
2008-03-06 2:16 ` Ping Yin
2008-03-06 4:10 ` Junio C Hamano [this message]
2008-03-06 5:56 ` Ping Yin
2008-03-06 10:42 ` Junio C Hamano
2008-03-06 11:36 ` Ping Yin
2008-03-02 18:15 ` [PATCH v3 3/4] git-submodule: New subcommand 'summary' (3) - limit summary size Ping Yin
2008-03-06 0:24 ` Junio C Hamano
2008-03-06 2:24 ` Ping Yin
2008-03-07 1:50 ` Ping Yin
2008-03-02 18:15 ` [PATCH v3 4/4] git-submodule: New subcommand 'summary' (4) - Update the document Ping Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3ar4lcgf.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pkufranky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).