From: Junio C Hamano <gitster@pobox.com>
To: "Whit Armstrong" <armstrong.whit@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: t4109-apply-multifrag.sh problem on solaris -- looks like problem w/ solaris patch cmd
Date: Tue, 04 Mar 2008 11:32:20 -0800 [thread overview]
Message-ID: <7v3ar670aj.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <8ec76080803040822n5e463b50sff6639777246de7b@mail.gmail.com> (Whit Armstrong's message of "Tue, 4 Mar 2008 11:22:58 -0500")
"Whit Armstrong" <armstrong.whit@gmail.com> writes:
> * expecting success: git apply patch1.patch patch2.patch patch3.patch
> * ok 4: S = git apply (2)
>
> * expecting success: cat patch1.patch patch2.patch patch3.patch | patch -p1
> patching file main.c
> patching file main.c
> patching file main.c
> * ok 5: S = patch (2)
> ...
>
> Is the answer to use GNU patch? Or is there a trick to make the
> Solaris version of patch work?
If we are reasonably sure that we will not be needing to change these test
vectors (and because "git apply" is now solid, I think we are), I think
the best way to address this is to prepare a new t/t4109 directory, store
the expected output in there, and compare output from "git apply" that is
being tested with the precomputed test vectors.
prev parent reply other threads:[~2008-03-04 19:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 16:22 t4109-apply-multifrag.sh problem on solaris -- looks like problem w/ solaris patch cmd Whit Armstrong
2008-03-04 19:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3ar670aj.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=armstrong.whit@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).