git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Miller <davem@davemloft.net>
Cc: git@vger.kernel.org
Subject: Re: setup_path()
Date: Wed, 13 Feb 2008 12:00:40 -0800	[thread overview]
Message-ID: <7v3arwpqxj.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080213.044915.123319879.davem@davemloft.net> (David Miller's message of "Wed, 13 Feb 2008 04:49:15 -0800 (PST)")

David Miller <davem@davemloft.net> writes:

> Shouldn't stand-alone programs other than git.c itself also call
> setup_path()?
>
> I have a problem where if I only install git into my own home
> directory ~/bin, I can't send pull requests over SSH to that machine
> successfully because the execvp() of "pack-objects" by git-upload-pack
> fails due to the PATH not containing "git --exec-dir"
>
> If I add a dummy setup_path(NULL) call to upload-pack.c, it works
> fine.

Yeah, Johannes Sixt had a patch to do exactly that earlier

	Message-ID: <47B182C1.60006@viscovery.net>
	http://news.gmane.org/gmane.comp.version-control.git/73651

and I think it is a good idea to apply it.

  reply	other threads:[~2008-02-13 20:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 12:49 setup_path() David Miller
2008-02-13 20:00 ` Junio C Hamano [this message]
2008-02-14  1:54   ` setup_path() David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v3arwpqxj.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=davem@davemloft.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).