From: Junio C Hamano <gitster@pobox.com>
To: Bruno Ribas <ribas@c3sl.ufpr.br>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: Adding gitweb.owner, last shot
Date: Thu, 07 Feb 2008 23:38:44 -0800 [thread overview]
Message-ID: <7v3as3lwxn.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1202445714-28971-1-git-send-email-ribas@c3sl.ufpr.br> (Bruno Ribas's message of "Fri, 8 Feb 2008 02:41:52 -0200")
Bruno Ribas <ribas@c3sl.ufpr.br> writes:
> ... there is no major performance downgrade
> compared to $projects_list , as seen below:
>
> 8<-------
> These times i got with a 1000projects running 2 dd to generate disk IO.
> Here comes the resultm
> NO projects_list projects_list
> 16m30s69 15m10s74 default gitweb, using FS's owner
> 16m07s40 15m24s34 patched to get gitweb.owner
> 16m37s76 15m59s32 same above, but without gitweb.owner
>
> Now results for a 1000projects on an idle machine.
> NO projects_list projects_list
> 1m19s08 1m09s55 default gitweb, using FS's owner
> 1m17s58 1m09s55 patched to get gitweb.owner
> 1m18s49 1m08s96 same above, but without gitweb.owner
> 8<-------
Large installations would maintain the project_list in the flat
file format for performance reasons anyway. Benchmarking under
a condition that yields unreasonably long response time is
somewhat meaningless, I am afraid. Who sane would wait for 15
minutes for project list to come up?
So I think your patch makes sense. It would not help nor hurt
large installations, and would help smaller installations that
do not care much about performance but are more interested in
the convenience of not having to worry about maintaining the
project_list.
As the act of signing off patches is a legal statement, I'd
prefer real person's name, not "Git Managment for C3SL", in the
messages to be applied. The change that adds the feature, and
the documentation update to describe that new feature, should be
in the same single patch for a small change like this.
next prev parent reply other threads:[~2008-02-08 7:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 4:41 Adding gitweb.owner, last shot Bruno Ribas
2008-02-08 4:41 ` [PATCH] gitweb: Use the config file to set repository owner's name Bruno Ribas
2008-02-08 4:41 ` [PATCH] gitweb: Update gitweb/README to include the new per-repository gitweb.owner Bruno Ribas
2008-02-08 10:55 ` [PATCH] gitweb: Use the config file to set repository owner's name Jakub Narebski
2008-02-08 13:53 ` Bruno Cesar Ribas
2008-02-08 14:30 ` Bruno Cesar Ribas
2008-02-08 15:33 ` Jakub Narebski
2008-02-08 16:07 ` Bruno Cesar Ribas
2008-02-08 7:38 ` Junio C Hamano [this message]
2008-02-08 13:49 ` Adding gitweb.owner, last shot Bruno Cesar Ribas
2008-02-08 10:34 ` Jakub Narebski
2008-02-08 13:51 ` Bruno Cesar Ribas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3as3lwxn.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ribas@c3sl.ufpr.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).