From: Junio C Hamano <gitster@pobox.com>
To: "Kristian Høgsberg" <krh@redhat.com>
Cc: git@vger.kernel.org
Subject: Re: config.c fixes
Date: Fri, 14 Dec 2007 11:43:00 -0800 [thread overview]
Message-ID: <7v3au5rrjv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071214192852.GA24187@bitplanet.net> (Kristian Høgsberg's message of "Fri, 14 Dec 2007 14:28:52 -0500")
Kristian Høgsberg <krh@redhat.com> writes:
> While strace'ing builtin-clone I saw this horror:
> I think the best solution is to just parse up the entire config file
> up front and keep it in a data structure, make the changes and then
> write it all out at the end.
Yeah, that was what I suggested a few times when other people have done
config writing side, but without successfully getting past their skulls
(it is not Linus's nor my code). It's about time somebody started to
clean up that mess.
The timing is a bit unfortunate, though. I would have preferred to have
a week or so to cook this in 'next' before merging it part of -rc0.
next prev parent reply other threads:[~2007-12-14 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 19:28 config.c fixes Kristian Høgsberg
2007-12-14 19:43 ` Junio C Hamano [this message]
2007-12-14 20:19 ` Kristian Høgsberg
-- strict thread matches above, loose matches on Subject: below --
2007-12-14 19:22 Kristian Høgsberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3au5rrjv.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=krh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).