From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: gitzilla@gmail.com,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH] t9600: require cvsps 2.1 to perform tests
Date: Tue, 04 Dec 2007 21:44:38 -0800 [thread overview]
Message-ID: <7v3auh3dbt.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071205010202.GA4713@coredump.intra.peff.net> (Jeff King's message of "Tue, 4 Dec 2007 20:02:02 -0500")
Jeff King <peff@peff.net> writes:
> On Tue, Dec 04, 2007 at 09:39:59AM -0800, Junio C Hamano wrote:
>
>> You are right about "we may be depending on what 2.1 has other than
>> -A". Will apply as-is.
>>
>> Thanks, both.
>>
>> The primary reason I asked about '\[-A\]' was what will happen if
>> somebody uses 2.2.
>
> Yes, it would be nice to be able to easily check >2.1. GNU expr seems to
> handle this ok:
>
> $ expr 2.2 '>' 2.1
> 1
> $ expr 2.0 '>' 2.1
> 0
>
> but POSIX seems to mention only integers and string comparison (though
> if all are of the form "x.y", string comparison works). I have no idea
> how portable this is.
Yeah, but it is the same thing -- we know 2.1 works, we do not know if
2.2 will break things for us ;-)
We'll worry about it when somebody with 2.2 complains.
prev parent reply other threads:[~2007-12-05 5:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 12:29 make test failure with latest master A Large Angry SCM
2007-12-02 12:52 ` Jakub Narebski
2007-12-02 14:01 ` A Large Angry SCM
2007-12-02 16:34 ` Jeff King
2007-12-02 23:19 ` A Large Angry SCM
2007-12-02 23:41 ` Johannes Schindelin
2007-12-03 1:59 ` Jeff King
2007-12-03 7:33 ` Johannes Sixt
2007-12-03 7:35 ` Jeff King
2007-12-03 23:10 ` A Large Angry SCM
2007-12-03 23:21 ` Junio C Hamano
2007-12-03 23:25 ` A Large Angry SCM
2007-12-04 1:41 ` [PATCH] t9600: require cvsps 2.1 to perform tests Jeff King
2007-12-04 5:37 ` Junio C Hamano
2007-12-04 15:44 ` Jeff King
2007-12-04 17:39 ` Junio C Hamano
2007-12-05 1:02 ` Jeff King
2007-12-05 5:44 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3auh3dbt.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitzilla@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).