From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Do check_repository_format() early
Date: Fri, 30 Nov 2007 18:36:03 -0800
Message-ID: <7v3aunb0q4.fsf@gitster.siamese.dyndns.org>
References: <20071128165837.GA5903@laptop>
	<Pine.LNX.4.64.0711281703470.27959@racer.site>
	<fcaeb9bf0711280910x40fecdd5mf6d86e4a9b656d01@mail.gmail.com>
	<Pine.LNX.4.64.0711281717460.27959@racer.site>
	<fcaeb9bf0711280924v34160eddsf8a75f8f8cee389c@mail.gmail.com>
	<Pine.LNX.4.64.0711281810410.27959@racer.site>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
X-From: git-owner@vger.kernel.org Sat Dec 01 03:36:37 2007
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1IyIDb-0003aU-FG
	for gcvg-git-2@gmane.org; Sat, 01 Dec 2007 03:36:35 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758242AbXLACgP (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Fri, 30 Nov 2007 21:36:15 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758230AbXLACgP
	(ORCPT <rfc822;git-outgoing>); Fri, 30 Nov 2007 21:36:15 -0500
Received: from sceptre.pobox.com ([207.106.133.20]:40218 "EHLO
	sceptre.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757962AbXLACgP (ORCPT <rfc822;git@vger.kernel.org>);
	Fri, 30 Nov 2007 21:36:15 -0500
Received: from sceptre (localhost.localdomain [127.0.0.1])
	by sceptre.pobox.com (Postfix) with ESMTP id 4BD2E2F2;
	Fri, 30 Nov 2007 21:36:30 -0500 (EST)
Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77])
	(using TLSv1 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	by sceptre.sasl.smtp.pobox.com (Postfix) with ESMTP id D10269BA0D;
	Fri, 30 Nov 2007 21:36:26 -0500 (EST)
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
Sender: git-owner@vger.kernel.org
Precedence: bulk
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/66677>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> On Thu, 29 Nov 2007, Nguyen Thai Ngoc Duy wrote:
>
>> The comment is clearly not clear enough. Maybe this?
>> 
>> +                     if (!work_tree_env) {
>> +                             retval = set_work_tree(gitdirenv);
>> +                             /* config may override worktree (see
>> set_work_tree comment) */
>> +                             check_repository_format();
>> +                             return retval;
>> +                     }
>
> Perfect.  Please make it so, and add my ACK.

Looks sensible, but can this be accompanied with a trivial test to
demonstrate the existing breakage?