git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Brian Gernhardt <benji@silverinsanity.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: t7005 and vi in GIT_EXEC_PATH
Date: Sun, 11 Nov 2007 11:43:02 -0800	[thread overview]
Message-ID: <7v3avcefg9.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <FCFF59B3-D3F1-4BEB-B3C3-D07DD5D5D8EF@silverinsanity.com> (Brian Gernhardt's message of "Sun, 11 Nov 2007 11:10:12 -0500")

Brian Gernhardt <benji@silverinsanity.com> writes:

> I'm sorry, I should have been more clear.  I was referring to the
> GIT_EXEC_PATH build variable, not the environment variable.  The git
> wrapper always adds the path determined during build to the front of
> PATH.  When I was changing my build script, this got set to "/usr/
> local/bin" (I usually use /usr/local/stow/git, instead).  Since I have
> a /usr/local/bin/vim, PATH for git-commit.sh during the test was:
>
> - my git build directory
> - /usr/local/bin (containing a symlink vi -> vim)
> - the t/trash directory, added by the test via `PATH=".:$PATH"`
> (containing the test vi script)
> - my normal path

Maybe that is what is broken.  t/test-lib.sh makes the
environment variable point at the build directory, and that
should override the path that is compiled in, shouldn't it?

  parent reply	other threads:[~2007-11-11 19:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-10 22:03 t7005 and vi in GIT_EXEC_PATH Brian Gernhardt
2007-11-10 22:09 ` David Kastrup
2007-11-10 22:45   ` Brian Gernhardt
2007-11-11 15:58 ` Johannes Schindelin
2007-11-11 16:10   ` Brian Gernhardt
2007-11-11 16:28     ` Johannes Schindelin
2007-11-11 19:43     ` Junio C Hamano [this message]
2007-11-11 20:33       ` [PATCH] Use the best available exec path only Björn Steinbrink
2007-11-11 20:50         ` Johannes Schindelin
2007-11-11 21:12           ` Jakub Narebski
2007-11-11 21:17           ` Björn Steinbrink
2007-11-11 21:40             ` Johannes Schindelin
2007-11-11 21:29       ` t7005 and vi in GIT_EXEC_PATH Junio C Hamano
2007-11-11 17:38 ` [PATCH] t7005-editor.sh: Don't invoke real vi when it is " Björn Steinbrink
2007-11-11 17:44   ` Johannes Schindelin
2007-11-11 17:49     ` Brian Gernhardt
2007-11-11 18:31       ` Johannes Schindelin
2007-11-11 18:01     ` Björn Steinbrink

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v3avcefg9.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=benji@silverinsanity.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).