git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <johannes.sixt@telecom.at>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] upload-pack: Use finish_{command,async}() instead of waitpid().
Date: Mon, 05 Nov 2007 12:05:40 -0800	[thread overview]
Message-ID: <7v3avkqwyz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200711042046.48257.johannes.sixt@telecom.at> (Johannes Sixt's message of "Sun, 4 Nov 2007 20:46:48 +0100")

Johannes Sixt <johannes.sixt@telecom.at> writes:

> - If pack-objects sees an error, it terminates with failure. Since this
>   breaks the pipe to rev-list, rev-list is killed with SIGPIPE.

I was a bit uneasy about this part.  We do not explicitly tell
rev-list not to ignore SIGPIPE, so it could spin fruitlessly
listing revs and calling write(2).  But the error from that
write should already be handled correctly anyway, so this should
be Ok.

> 	The test case checks for failures in rev-list (a missing
> 	object). Any hints how to trigger a failure in pack-objects
> 	that does not also trigger in rev-list would be welcome.

How about removing a blob from the test repository  to corrupt
it?  rev-list --objects I think would happily list the blob
because it sees its name in its containing tree without checking
its existence.

  parent reply	other threads:[~2007-11-05 20:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-04 19:46 [PATCH] upload-pack: Use finish_{command,async}() instead of waitpid() Johannes Sixt
2007-11-05  1:42 ` Michael J. Cohen
2007-11-05 20:05 ` Junio C Hamano [this message]
2007-11-05 21:40   ` [PATCH] t5530-upload-pack-error: Check more carefully for failures Johannes Sixt
2007-11-06  0:22     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v3avkqwyz.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.sixt@telecom.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).