From: Junio C Hamano <junkio@cox.net>
To: "Dana How" <danahow@gmail.com>
Cc: "Nicolas Pitre" <nico@cam.org>, "Junio C Hamano" <junkio@cox.net>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH 5/8] get-repack --max-pack-size: write_object() takes 'limit' arg
Date: Mon, 09 Apr 2007 13:09:44 -0700 [thread overview]
Message-ID: <7v3b39z4vr.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <56b7f5510704091220w69529e72n2f982c097c4e26a0@mail.gmail.com> (Dana How's message of "Mon, 9 Apr 2007 12:20:26 -0700")
"Dana How" <danahow@gmail.com> writes:
> For testing, I've been using git-fsck/git-verify-pack/git-unpack-objects .
Among the above, verify-pack does not do much more than what the
normal object reading path does already these days. Also
unpack-objects (especially with -n) omits a lot of object
integrity checks, and not very appropriate test.
We have some tests for packfiles in t/ (make test) but I would
not be surprised if we do not have enough. Most of the existing
tests are done on loose objects the tests themselves produce
without repacking, because their focus is not about packs and
they test whatever they are interested in, assuming that the
lowest level object layer is correctly functioning.
prev parent reply other threads:[~2007-04-09 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-08 23:24 [PATCH 5/8] get-repack --max-pack-size: write_object() takes 'limit' arg Dana How
2007-04-09 0:03 ` Junio C Hamano
2007-04-09 0:15 ` Junio C Hamano
2007-04-09 2:28 ` Nicolas Pitre
2007-04-09 0:40 ` Nicolas Pitre
2007-04-09 18:51 ` Dana How
2007-04-09 18:59 ` Nicolas Pitre
2007-04-09 19:20 ` Dana How
2007-04-09 19:25 ` Nicolas Pitre
2007-04-09 20:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3b39z4vr.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=danahow@gmail.com \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).