From: Junio C Hamano <junkio@cox.net>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] Command preparation cleanup in "connect.c"
Date: Sun, 10 Sep 2006 23:03:30 -0700 [thread overview]
Message-ID: <7v3bazndn1.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 200609110643.13486.chriscool@tuxfamily.org
Christian Couder <chriscool@tuxfamily.org> writes:
> The following two patches clean "connect.c" up using "add_to_string"
> from "rsh.c". The code is still longer, but there is no leak and it may be
> better to die with an error message than to truncate a too long command.
Nice, clean, simple and obviously correct.
Thanks.
prev parent reply other threads:[~2006-09-11 6:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-07 3:59 [PATCH] Fix memory leak in "connect.c" Christian Couder
2006-09-07 4:09 ` Junio C Hamano
2006-09-11 4:43 ` [PATCH 0/2] Command preparation cleanup in "connect.c" (was: [PATCH] Fix memory leak in "connect.c".) Christian Couder
2006-09-11 4:59 ` [PATCH 1/2] Move add_to_string to "quote.c" and make it extern Christian Couder
2006-09-11 5:04 ` [PATCH 2/2] Fix a memory leak in "connect.c" and die if command too long Christian Couder
2006-09-11 6:03 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3bazndn1.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).