Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: Re: log and diff family: honor config even from subdirectories
Date: Fri, 28 Jul 2006 18:54:24 -0700	[thread overview]
Message-ID: <7v3bclkwfj.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0607281811580.4168@g5.osdl.org> (Linus Torvalds's message of "Fri, 28 Jul 2006 18:17:25 -0700 (PDT)")

Linus Torvalds <torvalds@osdl.org> writes:

> I'd actually _like_ to do the setup unconditionally inside the git wrapper 
> (early - to make sure that we don't have this bug), but some things (at 
> least "init-db", "clone" and "ls-remote") are obviously not supposed to do 
> it, since they work outside of a git directory. So either we need to do it 
> in each builtin command separately, or we'd need to add a flag in the 
> command descriptor array.
>
> Any clever ideas?
>
> 		Linus

No clever ideas, but I agree it would be _very_ nice if we could
do the setup unconditionally and early.  Some commands that call
setup want to know prefix, so we would need to introduce a
global to hold the prefix for them.

I do not do this myself, but it is conceivable that you might
want to be able to set GIT_DIR to point at somewhere outside
your working tree hierarchy, _and_ still work in a subdirectory.
The current setup does not allow you to do that; we could
introduce GIT_PROJECT_ROOT environment variable, and when
GIT_PROJECT_ROOT exists difference between getcwd() and the
project root could become the value of prefix.

  reply	other threads:[~2006-07-29  1:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-29  1:17 log and diff family: honor config even from subdirectories Linus Torvalds
2006-07-29  1:54 ` Junio C Hamano [this message]
2006-07-29  4:21   ` Call setup_git_directory() early Linus Torvalds
2006-07-29  4:41     ` An alternative: call " Junio C Hamano
2006-07-29  5:06     ` Call " Junio C Hamano
2006-07-29  5:44       ` Linus Torvalds
2006-07-29  9:12         ` Junio C Hamano
2006-07-29 16:52           ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v3bclkwfj.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox