From: Junio C Hamano <gitster@pobox.com>
To: John Keeping <john@keeping.me.uk>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] add--interactive: respect diff.algorithm
Date: Sun, 23 Jun 2013 13:37:00 -0700 [thread overview]
Message-ID: <7v4ncoftsj.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130623195017.GI4676@serenity.lan> (John Keeping's message of "Sun, 23 Jun 2013 20:50:18 +0100")
John Keeping <john@keeping.me.uk> writes:
> The patch below involves deeper Perl magic than I fully grok, but
> wouldn't it be simpler to simply use the fact that the string is
> "command --options..." and use:
>
> splice @diff_cmd 1, 0, "--diff-algorithm=${diff_algorithm}";
That inserts the extra options as the first thing on the command
line, which is also fine.
prev parent reply other threads:[~2013-06-23 20:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 14:28 Different diff strategies in add --interactive John Keeping
2013-06-10 19:28 ` Junio C Hamano
2013-06-10 21:11 ` Jeff King
2013-06-10 21:46 ` John Keeping
2013-06-10 21:56 ` Jeff King
2013-06-12 18:44 ` [PATCH] add--interactive: respect diff.algorithm John Keeping
2013-06-12 19:18 ` Jeff King
2013-06-23 19:19 ` Junio C Hamano
2013-06-23 19:50 ` John Keeping
2013-06-23 20:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4ncoftsj.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).