From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
git@vger.kernel.org, Duy Nguyen <pclouds@gmail.com>
Subject: Re: [PATCH] lookup_object: prioritize recently found objects
Date: Thu, 02 May 2013 08:38:33 -0700 [thread overview]
Message-ID: <7v4nel2xza.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130502064630.GA15208@sigill.intra.peff.net> (Jeff King's message of "Thu, 2 May 2013 02:46:30 -0400")
Jeff King <peff@peff.net> writes:
> I figured the lengthy description in the commit message would be
> sufficient, but I don't mind adding something like your suggestion to
> point readers of the code in the right direction when they see it.
Yeah, I'll squash J6t's comment in and requeue.
If somebody is learning the internals by reading code, having a
comment there would certainly help.
prev parent reply other threads:[~2013-05-02 15:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 20:34 [PATCH] lookup_object: prioritize recently found objects Jeff King
2013-05-01 21:57 ` Junio C Hamano
2013-05-02 6:44 ` Johannes Sixt
2013-05-02 6:46 ` Jeff King
2013-05-02 7:05 ` Johannes Sixt
2013-05-02 15:46 ` Junio C Hamano
2013-05-02 15:50 ` Jeff King
2013-05-02 15:46 ` Jeff King
2013-05-03 5:59 ` Johannes Sixt
2013-05-03 6:02 ` Jeff King
2013-05-03 6:16 ` Jeff King
2013-05-02 15:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4nel2xza.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).